refactor: Rename symbols in TaskFieldRenderer #2440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create
TaskFieldRenderer
class inTaskFieldRenderer.ts
.Rename:
FieldLayouts
toTaskFieldRenderer
FieldLayoutDetail
toTaskFieldHTMLData
FieldLayoutDetails
totaskFieldHTMLData
Also:
TaskLineRenderer.taskToHtml()
now callsli.dataset()
directly instead of returning values to applyMotivation and Context
Classes with names one can remember =)
How has this been tested?
Unit tests.
Types of changes
refactor
- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test
- additions and improvements to unit tests and the smoke tests)Checklist
yarn run lint
.Terms